Add an external Serde code generator #254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d in release mode; test that it roudtrips
erickt
force-pushed
the
serde-code-generator
branch
from
0914929 to
8823ca7
Compare
SimonSapin
pushed a commit
that referenced
this pull request
Dec 19, 2016
SimonSapin
pushed a commit
that referenced
this pull request
Dec 19, 2016
SimonSapin
pushed a commit
that referenced
this pull request
Dec 19, 2016
|
Thanks Erick! That’s an interesting pattern. Closing as #259 removes the need for this, though. |
SimonSapin
pushed a commit
that referenced
this pull request
Jan 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon #252 to use an external serde code generator to avoid forcing downstream components to use
serde_codegen. IfUrlandHostever need to be modified, just updatesrc/codegen/url.rs.inandsrc/codegen/host.rs.in, then runcd serde-code-generator && cargo run.This change is