Prevent panic when calling url::Url::set_host with None.
#244
+23
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @SimonSapin |
|
Note this line from the URL spec:
So both set_host(None) and set_host("") should probably fail if SchemeType::from(self.scheme()).is_special() So while the test should not crash, the result should not be https:/hello |
|
@SimonSapin Do you remember why there is logic here for the 'cannot-be-a-base-URL' flag? At least for the link that @valenting sent, it doesn't look like that logic needs to be here. |
Manishearth
force-pushed
the
sethostnone
branch
from
f82eb26 to
b0d6060
Compare
Manishearth
force-pushed
the
sethostnone
branch
from
b0d6060 to
2c9e076
Compare
|
@bors-servo r+ |
|
📌 Commit 2c9e076 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Dec 17, 2016
Prevent panic when calling `url::Url::set_host` with `None`. Fixes #243. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/244) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #243.
This change is