Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate highfive with GitHub's reviews. #160

Open
emilio opened this issue Oct 20, 2016 · 2 comments
Open

Integrate highfive with GitHub's reviews. #160

emilio opened this issue Oct 20, 2016 · 2 comments

Comments

@emilio
Copy link
Member

emilio commented Oct 20, 2016

See for example servo/servo#13729, where the tags were manually added because highfive didn't detect that it was reviewed.

Don't know how GitHub's API exposes this though.
@jdm
Copy link
Member

jdm commented Oct 20, 2016

https://platform.github.community/t/how-can-we-approve-or-request-changes-on-pull-requests-using-api/350 says this can't be done through the API yet.

@jdm
Copy link
Member

jdm commented Oct 20, 2016

Ooh, nevermind. Looks like there was a webhook added recently: https://developer.github.com/v3/activity/events/types/#pullrequestreviewevent

Mark-Simulacrum pushed a commit to Mark-Simulacrum/highfive that referenced this issue Sep 8, 2020
@davidalber
Merge pull request servo#160 from rust-lang-nursery/nikomatsakis-patch-2
a4f6fe7 
add varkor, oli-obk to compiler team review list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdm @emilio