Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change simd to repr simd & bump version number #101

Merged
merged 1 commit into from
Aug 29, 2015
Merged

Change simd to repr simd & bump version number #101

merged 1 commit into from
Aug 29, 2015

Conversation

bjwbell
Copy link
Contributor

@bjwbell bjwbell commented Aug 28, 2015

With SIMD groundwork part 1
the simd feature is now repr_simd.

Bump the version number since this relies on the rust PR.

r? @metajack

Review on Reviewable

With [SIMD groundwork part
1](rust-lang/rust#27169)
the simd feature is now repr_simd.
@metajack
Copy link
Contributor

@bors-servo r+


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from the review on Reviewable.io

@bors-servo
Copy link
Contributor

📌 Commit 0258f4d has been approved by metajack

@bors-servo
Copy link
Contributor

⌛ Testing commit 0258f4d with merge 36f76d4...

bors-servo pushed a commit that referenced this pull request Aug 28, 2015
Change simd to repr simd & bump version number

With [SIMD groundwork part 1](rust-lang/rust#27169)
the simd feature is now repr_simd.

Bump the version number since this relies on the rust PR. 

r? @metajack

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/euclid/101)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - travis

@bjwbell
Copy link
Contributor Author

bjwbell commented Aug 29, 2015

Aster needs to be updated to work with rust-lang/rust#28033.
After that the build will succeed.

I submitted serde-deprecated/aster#28 to aster.

@erickt
Copy link

erickt commented Aug 29, 2015

Aster's been updated. 0.4.4 should work for you now.

@jdm
Copy link
Member

jdm commented Aug 29, 2015

@bors-servo: retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 0258f4d with merge 077ae54...

bors-servo pushed a commit that referenced this pull request Aug 29, 2015
Change simd to repr simd & bump version number

With [SIMD groundwork part 1](rust-lang/rust#27169)
the simd feature is now repr_simd.

Bump the version number since this relies on the rust PR. 

r? @metajack

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/euclid/101)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - travis

@bors-servo bors-servo merged commit 0258f4d into servo:master Aug 29, 2015
frewsxcv added a commit to frewsxcv/servo that referenced this pull request Sep 2, 2015
frewsxcv added a commit to frewsxcv/servo that referenced this pull request Sep 2, 2015
frewsxcv added a commit to frewsxcv/servo that referenced this pull request Sep 2, 2015
bors-servo pushed a commit to servo/servo that referenced this pull request Sep 2, 2015
Upgrade some dependencies to silence warnings

In order to pick up these changes:

* servo/euclid#101
* netvl/xml-rs#102
* mozilla/webdriver-rust#17
* servo/surfman#27

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7513)
<!-- Reviewable:end -->
jrmuizel pushed a commit to jrmuizel/gecko-cinnabar that referenced this pull request Jun 12, 2017
…rom frewsxcv:bump-no-warnings); r=Ms2ger

In order to pick up these changes:

* servo/euclid#101
* netvl/xml-rs#102
* mozilla/webdriver-rust#17
* servo/surfman#27

Source-Repo: https://github.com/servo/servo
Source-Revision: b7c88dd547c01d99c77c90329cc09f13a90a53b7
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Sep 30, 2019
…rom frewsxcv:bump-no-warnings); r=Ms2ger

In order to pick up these changes:

* servo/euclid#101
* netvl/xml-rs#102
* mozilla/webdriver-rust#17
* servo/surfman#27

Source-Repo: https://github.com/servo/servo
Source-Revision: b7c88dd547c01d99c77c90329cc09f13a90a53b7

UltraBlame original commit: 5cbc0613749c34c6cfb1b95223a695776d5c70f9
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 1, 2019
…rom frewsxcv:bump-no-warnings); r=Ms2ger

In order to pick up these changes:

* servo/euclid#101
* netvl/xml-rs#102
* mozilla/webdriver-rust#17
* servo/surfman#27

Source-Repo: https://github.com/servo/servo
Source-Revision: b7c88dd547c01d99c77c90329cc09f13a90a53b7

UltraBlame original commit: 5cbc0613749c34c6cfb1b95223a695776d5c70f9
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
…rom frewsxcv:bump-no-warnings); r=Ms2ger

In order to pick up these changes:

* servo/euclid#101
* netvl/xml-rs#102
* mozilla/webdriver-rust#17
* servo/surfman#27

Source-Repo: https://github.com/servo/servo
Source-Revision: b7c88dd547c01d99c77c90329cc09f13a90a53b7

UltraBlame original commit: 5cbc0613749c34c6cfb1b95223a695776d5c70f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants