Update to 2018 edition #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waywardmonkeys
force-pushed
the
update-to-2018-edition
branch
2 times, most recently
from
2fb2a68
to
11e4ad6
Compare
|
I'm in favour. |
waywardmonkeys
force-pushed
the
update-to-2018-edition
branch
from
11e4ad6
to
953b5da
Compare
|
@jdm Okay, marked as ready for review and rebased. Follow up PRs can do things like update to 2021 edition (MSRV is 1.56, so that's probably fine) and remove all of the |
|
@jdm Any further thoughts on this? |
|
@jrmuizel Any thoughts on this? |
|
I quickly skimmed it. Can you add a summary of what was changed to the commit message? |
This is the minimum fix required. It updates to use crate-relative imports.
waywardmonkeys
force-pushed
the
update-to-2018-edition
branch
from
953b5da
to
0f6067b
Compare
|
@jrmuizel Done. |
jrmuizel
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't get away from
extern crateyet.Is this set of changes welcome?