Update for stable Rust by removing the core feature #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for &(ref key, ref value) in pairs { | ||
| keys.push(key.as_CFTypeRef()); | ||
| values.push(value.as_CFTypeRef()); | ||
| } |
There was a problem hiding this comment.
Why did you need to remove the iterator usages?
There was a problem hiding this comment.
unzip is unfortunately unstable: http://doc.rust-lang.org/std/iter/trait.Iterator.html#tymethod.unzip
|
rust-lang/rust#23908 stabilized |
|
Convenient! I added back I'm waiting for another nightly that includes rust-lang/rust#23947 so I can test this, but it appears it'll work then. |
|
r+ |
brendanzab
added a commit
that referenced
this pull request
Apr 2, 2015
Update for stable Rust by removing the core feature
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Add support for CGContextSetTextDrawingMode <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-graphics-rs/60) <!-- Reviewable:end -->
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Upgrade core foundation This is a PR in a series of PRs originating at #132 The plan is to make a breaking change to `core-foundation` and release it as `0.5.0`. But before the merge/publish of `core-foundation` I will prepare a set of PRs making sure the entire dependency graph of Servo is ready for this change and can be switched over to `0.5.0` directly. TODO before merge: - [x] Merge `core-foundation` PR and publish. - [x] Remove the last commit from this PR, so we depend on code from crates.io. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/io-surface-rs/60) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It'd be great for libraries that depend on this crate if it worked on stable Rust. With the beta approaching soon, the unstable and deprecated APIs this crate uses are:
std::num::ToPrimitiveandstd::num::FromPrimitivestd::num::Int::max_valuestd::str::Str::as_sliceThis pull request replaces uses of this functionality.
The changes to
CFNumberare a breaking change, but I only found servo/rust-core-text and servo/rust-azure that would be impacted, and the fix is simple.