Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peer dependencies for axios auth refresh should also match dependencies #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gsingh4
Copy link

@gsingh4 gsingh4 commented Oct 7, 2022

axios .20 is the latest version as a supported requirement for axios auth refresh -- this package uses ~.21 so we need to bump peer dependency version

Copy link
Contributor

@bsmithwick bsmithwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsingh4 I just fixed this a few days ago (I think) with 7a3d910. Try reinstalling with npm install and see if the problem goes away.

@gsingh4
Copy link
Author

gsingh4 commented Nov 29, 2022

@bsmithwick you fixed it for dev dependencies but we also need it for peer dependencies too. I had to manually edit our package lock file to bump the peer dependency to get it to work when we were having issues. Sorry I forgot to follow up on this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants