Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change version command to use Cobra native way of doing versioning #12

Closed
TWinsnes opened this issue Aug 9, 2018 · 0 comments
Closed

Change version command to use Cobra native way of doing versioning #12

TWinsnes opened this issue Aug 9, 2018 · 0 comments
Assignees
@TWinsnes

Comments

@TWinsnes
Copy link
Contributor

TWinsnes commented Aug 9, 2018

Currently, versioning is done using a sub-command, the convention with Cobra is to use a flag. We should use the common convention for this rather than our own way.

Example:
https://github.com/nathandines/forge/blob/master/commands/root.go#L26-L36

This means the CI tools that expect the version sub-command will have to be updated to use the --version flag instead
@TWinsnes TWinsnes self-assigned this Aug 13, 2018
TWinsnes pushed a commit that referenced this issue Aug 13, 2018
Changed to follow Cobra convention for version flag on cli
ad30f6e 
To get the version you now have to use `--version` flag instead of the `version` sub-command.

Fixes: #12
@TWinsnes TWinsnes mentioned this issue Aug 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TWinsnes TWinsnes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TWinsnes