Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ added requirement.txt to track dependencies #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nwerker
Copy link

@nwerker nwerker commented Sep 20, 2024

This PR should be sufficient to add all dependencies for fully automated dependency mapping, when building execution environments that include this collection. See #19

@amarao
Copy link
Collaborator

amarao commented Oct 7, 2024

We use poetry for dependency management, with all dependencies listed in poetry.lock (which are calculated from pyproject.toml).

Can you elaborate what exactly requirements.txt will do in this case?

@nwerker
Copy link
Author

nwerker commented Oct 10, 2024

In this case ansible-builder the tool used to build execution environments automatically detects the python requirements in requirements.txt and installs it automatically, without the need to further specifiy it.

This will help streamline the build process of said exeuction environments for everybody using awx / ansible automation platform!

afaik pyproject.tom or poetry.lock can't be used by ansible-builder!

Maybe we can leverage poetry / pyproject.toml to automatically render the requirement.txt. I can understand that you don't want to maintain the dependencies in more than one place!

@amarao
Copy link
Collaborator

amarao commented Oct 30, 2024

Poetry can generate requirements.txt, but it does it from a lock file (that means, all versions of all packages is pinned down with exact version, down to hash). Will it work for you?

I don't want to keep two sources of dependencies (e.g. concurrent 'vague' requirements.txt and pyproject.toml), it causes confusion if they start to drift apart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants