Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added titles and descriptions to the DSL JSON Schema #968

Conversation

JBBianchi
Copy link
Member

@JBBianchi JBBianchi commented Aug 9, 2024

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:
#929

What this PR does:
This PR adds most missing titles and descriptions to the JSON Schema of the DSL.

Additional information:
I tried to enforce a consistent declaration order of type/title/description.

Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from some minor comments. Many thanks man ❤️

schema/workflow.yaml Outdated Show resolved Hide resolved
schema/workflow.yaml Outdated Show resolved Hide resolved
schema/workflow.yaml Outdated Show resolved Hide resolved
schema/workflow.yaml Outdated Show resolved Hide resolved
schema/workflow.yaml Outdated Show resolved Hide resolved
schema/workflow.yaml Outdated Show resolved Hide resolved
schema/workflow.yaml Outdated Show resolved Hide resolved
schema/workflow.yaml Outdated Show resolved Hide resolved
schema/workflow.yaml Outdated Show resolved Hide resolved
schema/workflow.yaml Outdated Show resolved Hide resolved
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
@cdavernas cdavernas merged commit be65792 into serverlessworkflow:main Aug 9, 2024
3 checks passed
@cdavernas cdavernas deleted the fix-929-schema-title-description branch August 9, 2024 12:36
@JBBianchi JBBianchi added change: documentation Improvements or additions to documentation. It won't impact a version change. area: spec Changes in the Specification labels Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: spec Changes in the Specification change: documentation Improvements or additions to documentation. It won't impact a version change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants