Update the specification.md and events.json to make both source and type eventDef properties optional
#678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `type` eventDef properties optional
cdavernas
requested review from
tsurdilo,
ricardozanini and
antmendoza
as code owners
| @@ -3271,8 +3271,8 @@ defined via the `parameters` property in [function definitions](#FunctionRef-Def | |||
| | Parameter | Description | Type | Required | | |||
| | --- | --- | --- | --- | | |||
| | name | Unique event name | string | yes | | |||
| | source | CloudEvent source | string | yes if kind is set to "consumed", otherwise no | | |||
| | type | CloudEvent type | string | yes | | |||
| | source | CloudEvent source | string | no if `type` is set, otherwise yes. If not set when `kind` is `produced`, runtimes are expected to use a default value, such as https://serverlessworkflow.io in order to comply with the [CloudEvent spec constraints](https://github.com/cloudevents/spec/blob/v1.0.2/cloudevents/spec.md#source-1) | | |||
There was a problem hiding this comment.
I'd say that "runtimes are expected to validate the incoming and outgoing CE to comply with CloudEvent spec constraints...". Not here, but in a paragraph after this table since this sentence suggests overall validation of CEs.
tsurdilo
added
the
change: feature
|
this needs entry in roadmap md |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
tsurdilo
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
Please specify parts of this PR update:
Discussion or Issue link:
#677 (comment)
#677 (comment)
What this PR does / why we need it:
Updates the specification.md and events.json to make both
sourceandtypeeventDef properties optional