Skip to content

Commit

Permalink
[Fix #742] Charles comments
Browse files Browse the repository at this point in the history
Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
  • Loading branch information
fjtirado committed Mar 8, 2024
1 parent 77c77b2 commit f38d9d0
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions schema/workflow.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
"properties": {
"name": {
"type": "string",
"description": "Workflow definition unique identifier (which must be human readable)",
"description": "The name that identifies the workflow definition, and which, when combined with its version, forms a unique identifier.",
"pattern": "^(0|[1-9]\\d*)\\.(0|[1-9]\\d*)\\.(0|[1-9]\\d*)(?:-((?:0|[1-9]\\d*|\\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\\.(?:0|[1-9]\\d*|\\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\\+([0-9a-zA-Z-]+(?:\\.[0-9a-zA-Z-]+)*))?$",
"minLength": 1
},
"version": {
Expand All @@ -20,7 +21,7 @@
},
"key": {
"type": "string",
"description": "Expression that will be used to generate a domain-specific workflow instance identifier"
"description": "Optional expression that will be used to generate a domain-specific workflow instance identifier"
},
"annotations": {
"type": "array",
Expand Down
4 changes: 2 additions & 2 deletions specification.md
Original file line number Diff line number Diff line change
Expand Up @@ -1925,10 +1925,10 @@ definition "name" must be a constant value.

| Parameter | Description | Type | Required |
| --- | --- | --- | --- |
| name | Workflow definition unique identifier (which must be human readable) | string | yes |
| name | The name that identifies the workflow definition, and which, when combined with its version, forms a unique identifier. | string | yes |
| version | Workflow version. MUST respect the [semantic versioning](https://semver.org/) format. If not provided, latest is assumed | string | no |
| description | Workflow description | string | no |
| key | Expression that will be used to generate a domain-specific workflow instance identifier | string | no |
| key | Optional expression that will be used to generate a domain-specific workflow instance identifier | string | no |
| annotations | List of helpful terms describing the workflows intended purpose, subject areas, or other important qualities | array | no |
| dataInputSchema | Used to validate the workflow data input against a defined JSON Schema| string or object | no |
| dataOutputSchema | Used to validate the workflow data output against a defined JSON Schema| string or object | no |
Expand Down

0 comments on commit f38d9d0

Please sign in to comment.