sdk-go proposal for DSL v1.0.0-alpha2 #204
Conversation
Signed-off-by: André R. de Miranda <[email protected]>
Signed-off-by: André R. de Miranda <[email protected]>
Signed-off-by: André R. de Miranda <[email protected]>
There was a problem hiding this comment.
Many thanks! I have a few observations before we merge this:
- We should migrate the testdata to the new DSL and reuse to validate the new parser
- The Kubernetes deepcopy/codegen should be re-added
I really liked the Lookup approach to fetch nodes from the workflow.
| package dsl | ||
|
|
||
| const DSLSpec = ` | ||
| $id: https://serverlessworkflow.io/schemas/1.0.0-alpha1/workflow.yaml |
There was a problem hiding this comment.
Maybe we can think of a way to update this automatically via CI. Once you open the issues to follow up on this PR, can you open this one? I can take care of it.
| @@ -37,7 +36,7 @@ import ( | |||
|
|
|||
| // ServerlessWorkflowSpec defines a base API for integration test with operator-sdk | |||
| type ServerlessWorkflowSpec struct { | |||
| model.Workflow `json:",inline"` | |||
| // model.Workflow `json:",inline"` | |||
There was a problem hiding this comment.
It was kept to adapt to the Kubernetes Controller in the future.
Will this Kubernetes folder be kept?
There was a problem hiding this comment.
Yes, the SDK must be compatible with Kubernetes objects.
There was a problem hiding this comment.
The kubernetes controller-gen requires struct to work.
I tested the tool (https://github.com/omissis/go-jsonschema) to generate the struct, but it gives an error with interface when generating the code with deepcopy.
Using go-jsonschema or another tool seems like a solution.
Signed-off-by: André R. de Miranda <[email protected]>
Signed-off-by: André R. de Miranda <[email protected]>
Signed-off-by: André R. de Miranda <[email protected]>
| @@ -0,0 +1,2246 @@ | |||
| { | |||
| "$id": "https://serverlessworkflow.io/schemas/1.0.0/workflow.yaml", | |||
There was a problem hiding this comment.
This is a recurrent tech debt we have with other SDKs as well. Instead of reading from local, can we read from a URL? We have this: https://serverlessworkflow.io/schemas/1.0.0-alpha2/workflow.json
I'll automate publishing these schemas.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Discussion in the issue 203