-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bin process not always exiting #5349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jogold
Good point. Agreed with the approach.
LGTM 👍
FYI this is now breaking the |
This also seems to be breaking For example - when running this handler function with sls invoke local, the cli exits before the callback is run:
|
What did you implement:
Closes #5348
How did you implement it:
Add
.then(() => process.exit(0))
afterserverless.run()
in bin file.Todos:
Is this ready for review?: YES
Is it a breaking change?: NO