Add support for specifying custom dependency groups in Poetry #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mLupine
force-pushed
the
poetry_group_support
branch
from
2ceb4b1
to
e719337
Compare
|
Hey @mLupine - thanks a lot for the PR. I'll try to review it by the end of the week but I don't promise anything as I've been way too busy lately. |
|
Any updates? |
mLupine
added a commit
to mLupine/serverless-python-requirements
that referenced
this pull request
Nov 3, 2023
* master: Release v6.0.1 (serverless#793) ci: Temporarily disable test run on integrate (serverless#800) ci: Temporarily minimize testing matrix (serverless#799) ci: Fix test skips (serverless#797) ci: Temp skip of cache-related tests (serverless#796) ci: Remove node12 from testing matrix (serverless#795) fix: Not crash when runtime is not `python` (serverless#773) fix: Remove outdated Pipenv requirements flag (serverless#780) fix: Fix integration test matrix configuration (serverless#755) fix: Add legacy `pipenv` backward compatability (serverless#742) Add support for specifying custom dependency groups in Poetry (serverless#746) docs: Add contributing and code of conduct # Conflicts: # test.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poetry 1.2+ allows to create custom dependency groups in
pyproject.toml. However, theexportplugin (unlike theinstallcommand) does not include those dependencies by default, even if they're not marked as optional, resulting in them being missing from the Serverless deployment package. This PR introduces three new configuration parameters that directly wrap Poetry's--with,--withoutand--onlyparameters and allow to include dependencies from those missing groups in the exportedrequirements.txtfile.