VPC Naming and Egress Setting

[arei]

Fixes #242

This PR address to issues with defining VPC connectors for a google cloud function:

• First, VPC Connectors can be named with a url (which is the current pattern) or with just the name of the connector if it is within the same project and region. This is described here: https://cloud.google.com/functions/docs/reference/rest/v1/projects.locations.functions#resource:-cloudfunction
• Second, this PR adds the ability to specify a VPC Egress setting. This is done using the vpcEgress property in the serverless.yml file. This property can take one of four different values:
  • ALL_TRAFFIC
  • PRIVATE_RANGES_ONLY
  • ALL (A shortcut for ALL_TRAFFIC)
  • PRIVATE (A shortcut for PRIVATE_RANGES_ONLY)

Also added smattering of tests to verify these changes.

Enjoy.

[edgaregonzalez]

Hello, when we can have this feature available?
Thank you.

[pendexgabo]

would be useful for us as well. how can we help to get this merged.

[pgrzesik]

Thank you @arei - it looks good in general, I have a few comments, please let me know what do you think

[pgrzesik]

This new property should be added to configuration schema in provider/googleProvider.js

[fcr1193]

hey! how are you? sorry, I was trying to make these changes since these would be of great help to me.
I can't find where to add that property in that file. Would you help me?

Thank you!

[pgrzesik]

Hello 👋 The schema for provider and function properties is here:

serverless-google-cloudfunctions/provider/googleProvider.js

Lines 103 to 129 in e6e0799

	provider: {
	properties: {
	credentials: { type: 'string' },
	project: { type: 'string' },
	region: { $ref: '#/definitions/cloudFunctionRegion' },
	runtime: { $ref: '#/definitions/cloudFunctionRuntime' }, // Can be overridden by function configuration
	serviceAccountEmail: { type: 'string' }, // Can be overridden by function configuration
	memorySize: { $ref: '#/definitions/cloudFunctionMemory' }, // Can be overridden by function configuration
	timeout: { type: 'string' }, // Can be overridden by function configuration
	environment: { $ref: '#/definitions/cloudFunctionEnvironmentVariables' }, // Can be overridden by function configuration
	vpc: { type: 'string' }, // Can be overridden by function configuration
	labels: { $ref: '#/definitions/resourceManagerLabels' }, // Can be overridden by function configuration
	},
	},
	function: {
	properties: {
	handler: { type: 'string' },
	runtime: { $ref: '#/definitions/cloudFunctionRuntime' }, // Override provider configuration
	serviceAccountEmail: { type: 'string' }, // Override provider configuration
	memorySize: { $ref: '#/definitions/cloudFunctionMemory' }, // Override provider configuration
	timeout: { type: 'string' }, // Override provider configuration
	environment: { $ref: '#/definitions/cloudFunctionEnvironmentVariables' }, // Override provider configuration
	vpc: { type: 'string' }, // Override provider configuration
	labels: { $ref: '#/definitions/resourceManagerLabels' }, // Override provider configuration
	},
	},
	});

[pgrzesik]

I believe I might be missing something here - if we're only checking for setting on funcObject, does that mean that setting on provider level will always be ineffective?

[pgrzesik]

isn't that check redundant? The whole if will be executed only if funcObject has vpcEgress set, which means that egress will always be set.

[pgrzesik]

This check can be achieved by proper schema definition in for vpcEgress property

[pgrzesik]

I'm closing this one in favor of: #271