Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kubernetes Helm chart (#448) #484

Merged
merged 2 commits into from
Aug 1, 2018
Merged

Conversation

baniol
Copy link
Contributor

@baniol baniol commented Jul 23, 2018

What did you implement:

Closes #448

How did you implement it:

This is a basic, non-prod setup, as it lacks some features, like RBAC for etcd and Event Gateway or TLS for etcd.
More details regarding etcd installation https://github.com/coreos/etcd-operator/tree/master/doc/user.
I think the question is if we want to leave the initial implementation like this (just for playing around with EG on K8s), or it should be as much prod-ready as possible at the start.

Currently, there's only one external service (LoadBalancer), exposing both config and events ports. Probably a better options would be to have 2 services with ingress in front. The problem is that events api doesn't expose a health check endpoint.

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@codecov
Copy link

codecov bot commented Jul 23, 2018

Codecov Report

Merging #484 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #484   +/-   ##
======================================
  Coverage    71.2%   71.2%           
======================================
  Files          37      37           
  Lines        2195    2195           
======================================
  Hits         1563    1563           
  Misses        571     571           
  Partials       61      61

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de6e4e0...205dae1. Read the comment docs.

@mthenw mthenw requested a review from sebito91 July 23, 2018 08:23
@mthenw
Copy link
Contributor

mthenw commented Jul 24, 2018

@baniol wow, thanks for your contribution. @sebito91 is more familiar with k8s ecosystem and he will review it.

@sebito91 sebito91 self-assigned this Jul 26, 2018
@sebito91 sebito91 added the WIP label Jul 26, 2018
@sebito91
Copy link
Contributor

@baniol I think this is wonderfully done, thank you very much for your contribution! We're in the process of flushing this out internally but I'll gladly accept and merge this PR.

Can you please rebase your code against the latest changes? Once that's that done we can merge.

Once again thank you very much for the contribution, it'll help to have both helm and CRD versions defined in our infra moving forward!

Copy link
Contributor

@sebito91 sebito91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this is excellent work, definitely helps to have a helm chart to assist with deploying the gateway.

If you can please rebase the code we'll gladly merge the PR.

@sebito91 sebito91 merged commit 5c2d4e1 into serverless:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants