Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list CORS configurations endpoint #463

Merged
merged 3 commits into from
Jun 15, 2018
Merged

Add list CORS configurations endpoint #463

merged 3 commits into from
Jun 15, 2018

Conversation

mthenw
Copy link
Contributor

@mthenw mthenw commented Jun 15, 2018

What did you implement:

Closes #XXXXX

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

@codecov
Copy link

codecov bot commented Jun 15, 2018

Codecov Report

Merging #463 into master will increase coverage by 0.27%.
The diff coverage is 92%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #463      +/-   ##
=========================================
+ Coverage   68.22%   68.5%   +0.27%     
=========================================
  Files          34      34              
  Lines        2112    2137      +25     
=========================================
+ Hits         1441    1464      +23     
- Misses        611     612       +1     
- Partials       60      61       +1
Impacted Files Coverage Δ
httpapi/httpapi.go 79.75% <100%> (+0.61%) ⬆️
libkv/cors.go 88.88% <84.61%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6821c0a...b0ac94f. Read the comment docs.

@mthenw mthenw merged commit 31dd993 into master Jun 15, 2018
@mthenw mthenw deleted the list-cors branch June 15, 2018 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant