Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events API Authorization (Event Type Authorizer) #441

Merged
merged 11 commits into from
Jun 6, 2018
Merged

Events API Authorization (Event Type Authorizer) #441

merged 11 commits into from
Jun 6, 2018

Conversation

mthenw
Copy link
Contributor

@mthenw mthenw commented Jun 5, 2018

What did you implement:

Authorizer for event type

How did you implement it:

TODO

Todos:

  • remove space from metricEventsDropped metric
  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO
Is it a breaking change?: YES

@codecov
Copy link

codecov bot commented Jun 5, 2018

Codecov Report

Merging #441 into master will decrease coverage by 0.63%.
The diff coverage is 46.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
- Coverage   65.38%   64.74%   -0.64%     
==========================================
  Files          32       32              
  Lines        1788     1835      +47     
==========================================
+ Hits         1169     1188      +19     
- Misses        573      596      +23     
- Partials       46       51       +5
Impacted Files Coverage Δ
router/wait.go 0% <0%> (ø)
internal/cache/target.go 0% <0%> (ø) ⬆️
router/metrics.go 35.29% <0%> (-17.65%) ⬇️
event/type.go 0% <0%> (ø) ⬆️
libkv/eventtype.go 87.87% <100%> (+0.78%) ⬆️
internal/cache/subscription_cache.go 86.76% <100%> (+0.61%) ⬆️
router/router.go 62.83% <61.71%> (+8.91%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68bcaf6...2f2544d. Read the comment docs.

@mthenw mthenw changed the title Events API Authorization Events API Authorization (Event Type Authorizer) Jun 6, 2018
@mthenw mthenw merged commit 50ebe47 into master Jun 6, 2018
@mthenw mthenw deleted the authorizer branch June 6, 2018 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant