Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move metric definition to the same file as other metrics #424

Merged
merged 1 commit into from
May 11, 2018
Merged

Conversation

mthenw
Copy link
Contributor

@mthenw mthenw commented May 11, 2018

Minor refactor.

@codecov
Copy link

codecov bot commented May 11, 2018

Codecov Report

Merging #424 into master will decrease coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
- Coverage    63.9%   63.87%   -0.03%     
==========================================
  Files          29       29              
  Lines        1651     1650       -1     
==========================================
- Hits         1055     1054       -1     
  Misses        553      553              
  Partials       43       43
Impacted Files Coverage Δ
httpapi/config.go 0% <0%> (-8%) ⬇️
httpapi/metrics.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79dfe2e...9abaf1b. Read the comment docs.

@mthenw mthenw merged commit 517f1ec into master May 11, 2018
@mthenw mthenw deleted the move-metric branch May 11, 2018 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant