Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Content-Type application/cloudevents+json for http provider #415

Merged
merged 2 commits into from
Apr 27, 2018

Conversation

alexdebrie
Copy link
Contributor

What did you implement:

For the http function provider, I changed the Content-Type of the outgoing request to application/cloudevents+json. This is in accordance with the CloudEvents spec.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@alexdebrie alexdebrie requested a review from mthenw April 26, 2018 19:12
@codecov
Copy link

codecov bot commented Apr 26, 2018

Codecov Report

Merging #415 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #415   +/-   ##
=======================================
  Coverage   63.85%   63.85%           
=======================================
  Files          29       29           
  Lines        1649     1649           
=======================================
  Hits         1053     1053           
  Misses        553      553           
  Partials       43       43
Impacted Files Coverage Δ
providers/http/http.go 70% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e75ed0c...dbfde2c. Read the comment docs.

@mthenw mthenw merged commit 5bf5be8 into master Apr 27, 2018
@mthenw mthenw deleted the HttpContentType branch April 27, 2018 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants