Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS Firehose provider #394

Merged
merged 3 commits into from
Mar 23, 2018
Merged

Add AWS Firehose provider #394

merged 3 commits into from
Mar 23, 2018

Conversation

alexdebrie
Copy link
Contributor

What did you implement:

Added AWS Firehose provider.

How did you implement it:

Very similar to the Kinesis implementation from #392

How can we verify it:

  1. Create a Firehose stream in AWS.

  2. Create a Firehose "function" by calling the registerFunction API. Payload body should be:

{
    "functionId": "firehose-stream",
    "type": "awsfirehose",
    "provider": {
        "region": "<region-of-stream>",
        "awsAccessKeyId": "<access-key-with PutRecord permission>",
        "awsSecretAccessKey": "<secret-access-key>",
        "deliveryStreamName": "<name-of-stream>"
    }
}
  1. Create a subscription with the createSubscription API with the following payload:
{
	"functionId": "firehose-stream", 
	"event": "testFirehoseEvent"
}
  1. Invoke your event by calling the Events API with a header of event: testFireshoseEvent and a payload body that you wanted inserted to Firehose.

  2. Check your Firehose stream destination to make sure your record made it there.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@alexdebrie alexdebrie requested a review from mthenw March 20, 2018 15:23
@mthenw
Copy link
Contributor

mthenw commented Mar 20, 2018

@alexdebrie LGTM, not sure why codecov didn't trigger. I will try to figure out that.

@codecov
Copy link

codecov bot commented Mar 23, 2018

Codecov Report

Merging #394 into master will increase coverage by 0.85%.
The diff coverage is 79.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
+ Coverage   58.92%   59.78%   +0.85%     
==========================================
  Files          24       25       +1     
  Lines        1434     1477      +43     
==========================================
+ Hits          845      883      +38     
- Misses        546      551       +5     
  Partials       43       43
Impacted Files Coverage Δ
providers/awsfirehose/awsfirehose.go 79.06% <79.06%> (ø)
router/router.go 51.32% <0%> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c0374a...27d0b65. Read the comment docs.

@mthenw mthenw merged commit c909055 into master Mar 23, 2018
@mthenw mthenw deleted the Firehose branch March 23, 2018 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants