Fix nil pointer when checking for event authorizer (#475)

serverless · Jun 29, 2018 · 24c3c35 · 24c3c35
1 parent 0dd9f87
commit 24c3c35
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/libkv/function.go b/libkv/function.go
@@ -138,7 +138,7 @@ func (service Service) DeleteFunction(space string, id function.ID) error {
 		return err
 	}
 	for _, eventType := range eventTypes {
-		if id == *eventType.AuthorizerID {
+		if eventType.AuthorizerID != nil && id == *eventType.AuthorizerID {
 			return &function.ErrFunctionIsAuthorizer{ID: id, EventType: string(eventType.Name)}
 		}
 	}

diff --git a/libkv/function_test.go b/libkv/function_test.go
@@ -264,6 +264,7 @@ func TestDeleteFunction(t *testing.T) {
 
 	t.Run("function is authorizer", func(t *testing.T) {
 		kvs := []*store.KVPair{
+			{Value: []byte(`{"name":"test.event.noauth"}`)},
 			{Value: []byte(`{"name":"test.event","authorizerId":"testid"}`)}}
 		eventTypesDB := mock.NewMockStore(ctrl)
 		eventTypesDB.EXPECT().List("default/", &store.ReadOptions{Consistent: true}).Return(kvs, nil)