Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off 'require-atomic-updates' rule due to false positives #7

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Jul 5, 2019

It's an unfortunate new addition to eslint:recommended

e.g. it reports errors for this lines: https://github.com/serverless/enterprise-plugin/blob/e25dfeedab8c3ed7583867261ef96aaee3e0f050/src/lib/credentials.js#L18-L20

More info: eslint/eslint#11899

@medikoo medikoo self-assigned this Jul 5, 2019
Copy link

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@medikoo medikoo merged commit 0ea9c9f into master Jul 9, 2019
@medikoo medikoo deleted the turn-off-require-atomic-updates branch July 9, 2019 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants