Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-at-edge): fix fallback (non-prerendered) SSG requests not … #800

Merged
merged 3 commits into from
Nov 15, 2020

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Nov 15, 2020

…generating data in S3.

Fixes: #798

@codecov
Copy link

codecov bot commented Nov 15, 2020

Codecov Report

Merging #800 (ac7b2a5) into master (b10b6e5) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #800      +/-   ##
==========================================
+ Coverage   80.07%   80.23%   +0.16%     
==========================================
  Files          57       57              
  Lines        1862     1862              
  Branches      410      410              
==========================================
+ Hits         1491     1494       +3     
+ Misses        313      310       -3     
  Partials       58       58              
Impacted Files Coverage Δ
...ackages/libs/lambda-at-edge/src/default-handler.ts 94.77% <ø> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b10b6e5...ac7b2a5. Read the comment docs.

@dphang dphang merged commit 29719f5 into master Nov 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the dphang/fix-ssg-fallback branch November 15, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSG not storing to s3 for dynamic pages with fallback: true
1 participant