-
-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support AWS CDK V2 #2187
Support AWS CDK V2 #2187
Conversation
Handler Size Report
Base Handler Sizes (kB) (commit 7dc3544){
"Lambda": {
"Default Lambda": {
"Standard": 1525,
"Minified": 668
},
"Image Lambda": {
"Standard": 1489,
"Minified": 802
}
},
"Lambda@Edge": {
"Default Lambda": {
"Standard": 1534,
"Minified": 674
},
"Default Lambda V2": {
"Standard": 1527,
"Minified": 670
},
"API Lambda": {
"Standard": 634,
"Minified": 318
},
"Image Lambda": {
"Standard": 1496,
"Minified": 807
},
"Regeneration Lambda": {
"Standard": 1184,
"Minified": 545
},
"Regeneration Lambda V2": {
"Standard": 1254,
"Minified": 573
}
}
} New Handler Sizes (kB) (commit c812ca3){
"Lambda": {
"Default Lambda": {
"Standard": 1525,
"Minified": 668
},
"Image Lambda": {
"Standard": 1489,
"Minified": 802
}
},
"Lambda@Edge": {
"Default Lambda": {
"Standard": 1534,
"Minified": 674
},
"Default Lambda V2": {
"Standard": 1527,
"Minified": 670
},
"API Lambda": {
"Standard": 634,
"Minified": 318
},
"Image Lambda": {
"Standard": 1496,
"Minified": 807
},
"Regeneration Lambda": {
"Standard": 1184,
"Minified": 545
},
"Regeneration Lambda V2": {
"Standard": 1254,
"Minified": 573
}
}
} |
Codecov Report
@@ Coverage Diff @@
## master #2187 +/- ##
==========================================
+ Coverage 83.51% 83.53% +0.02%
==========================================
Files 102 102
Lines 3669 3669
Branches 1166 1166
==========================================
+ Hits 3064 3065 +1
+ Misses 593 592 -1
Partials 12 12
Continue to review full report at Codecov.
|
@dphang |
Thanks! I think it generally looks fine but just wondering is it backwards compatible for those upgrading from CDK v1 (or at least easy to upgrade)? Although maybe since it is marked as experimental anyway it should be fine to make slight breaking changes. |
@dphang |
LGTM, can you resolve the lockfile conflict first (guess there may have been some automated dependency updates) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. I've tested it and it works 🥇
"@sls-next/cdk-construct": "^3.2.0", | ||
"@sls-next/cdk-construct": "link:../../", | ||
"aws-cdk-lib": "2.0.0", | ||
"constructs": "10.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I wish the versions not be pinned to the patch level? Otherwise I'd have to override dependencies to overcome TypeScript strict errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2a9355d
to
6638e62
Compare
6638e62
to
9f53657
Compare
519de63
to
0a62b3c
Compare
@dphang I've made a new commit, so I no longer need you to respond to it! |
"@aws-cdk/core": "1.134.0" | ||
"aws-cdk": "2.0.0", | ||
"aws-cdk-lib": "2.0.0", | ||
"constructs": "10.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @n04h , I actually meant these package dependencies, not the dependencies of the example project which I commented about. I see those peer dependencies were pinned before your change. I think for TypeScript users it would make sense to allow patch (~
) if not minor (^
) version upgrades.
@n04h I've played around with cdk dependencies in my local fork and here is what I think might be the optimal configuration: shishkin@cbe4ff4#diff-31ab403361720bb5176a7892a6983567ec894b97dec186abeadd7a3ba17c9082. Feel free to cherry pick my commits in your PR and thanks for moving this forward! |
@shishkin |
LGTM, thanks! I'll merge it now to avoid any dependency conflicts, if any updates needed feel free to raise another PR |
Updated AWS CDK v2 used in @sls-next/cdk-construct.
resolved #2183
Example
https://d2a3l2x7qiiihp.cloudfront.net
https://d2a3l2x7qiiihp.cloudfront.net/api/hello
Reference
AWS CDK v2 Developer Guide
Migrating to AWS CDK v2