Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-at-edge): properly copy node_modules in serverless-trace mode for regeneration lambda #1319

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Jun 28, 2021

  • This wasn't working properly since copyTraces() was always copying to the default lambda directory. We need to pass in the directory.
  • Won't add tests since serverless-trace is already getting deprecated as of later Next.js versions (e.g 10.2.3) but manually tested.

Related: #1098

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #1319 (a72fc81) into master (f842e67) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1319   +/-   ##
=======================================
  Coverage   83.61%   83.61%           
=======================================
  Files          97       97           
  Lines        3345     3345           
  Branches     1001     1001           
=======================================
  Hits         2797     2797           
  Misses        486      486           
  Partials       62       62           
Impacted Files Coverage Δ
packages/libs/lambda-at-edge/src/build.ts 97.09% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f842e67...a72fc81. Read the comment docs.

@dphang dphang merged commit 0eee571 into master Jun 28, 2021
@dphang dphang deleted the dphang/fix-serverless-trace-copying branch August 3, 2021 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant