Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and stash packages only once in e2e tests #1079

Merged
merged 3 commits into from
May 18, 2021
Merged

Conversation

jvarho
Copy link
Collaborator

@jvarho jvarho commented May 18, 2021

Moves building packages and utils for e2e tests out of the matrix into the initialize step. This reduces the chance of failures due to one or more of the builds failing.

This may make it slower to run e2e tests (when there's no queue) because stashing the build takes an extra minute or so.

@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #1079 (8262004) into master (9e75d76) will not change coverage.
The diff coverage is n/a.

❗ Current head 8262004 differs from pull request most recent head 0761730. Consider uploading reports for the commit 0761730 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1079   +/-   ##
=======================================
  Coverage   83.10%   83.10%           
=======================================
  Files          79       79           
  Lines        3012     3012           
  Branches      839      839           
=======================================
  Hits         2503     2503           
  Misses        456      456           
  Partials       53       53           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e75d76...0761730. Read the comment docs.

@jvarho jvarho marked this pull request as ready for review May 18, 2021 14:19
@jvarho
Copy link
Collaborator Author

jvarho commented May 18, 2021

Won't help with flaky tests, of course. There's a single failure from a test that passed in master, which suggests the test is somehow wrong.

@kirkness kirkness mentioned this pull request May 18, 2021
13 tasks
@jvarho jvarho force-pushed the e2e-build-stash branch from e0d8791 to a37bc3d Compare May 18, 2021 14:59
@jvarho
Copy link
Collaborator Author

jvarho commented May 18, 2021

Ah, it's the same issue that I already fixed for several other tests in the same file. I.e. Next.js changes the location after the page has loaded. It sometimes passes if cypress checks the location before the transition has happened.

Copy link
Collaborator

@kirkness kirkness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@dphang
Copy link
Collaborator

dphang commented May 18, 2021

Great! This was on the TODO but just hadn't had a chance.

Still not sure why yarn sometimes continues even though one of the packages had an error code, though that can looked at separately

@dphang dphang merged commit cb305ee into master May 18, 2021
@delete-merged-branch delete-merged-branch bot deleted the e2e-build-stash branch May 18, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants