-
-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and stash packages only once in e2e tests #1079
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1079 +/- ##
=======================================
Coverage 83.10% 83.10%
=======================================
Files 79 79
Lines 3012 3012
Branches 839 839
=======================================
Hits 2503 2503
Misses 456 456
Partials 53 53 Continue to review full report at Codecov.
|
Won't help with flaky tests, of course. There's a single failure from a test that passed in master, which suggests the test is somehow wrong. |
Ah, it's the same issue that I already fixed for several other tests in the same file. I.e. Next.js changes the location after the page has loaded. It sometimes passes if cypress checks the location before the transition has happened. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
Great! This was on the TODO but just hadn't had a chance. Still not sure why yarn sometimes continues even though one of the packages had an error code, though that can looked at separately |
Moves building packages and utils for e2e tests out of the matrix into the initialize step. This reduces the chance of failures due to one or more of the builds failing.
This may make it slower to run e2e tests (when there's no queue) because stashing the build takes an extra minute or so.