-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unstable_revalidate supported ? #559
Comments
I believe this is part of Incremental Static Regeneration, I think it is discussed here: #355 (comment) but not yet implemented as far as I know. |
I hope unstable_revalidate will be supported soon |
That means, currently, the Incremental Static Regeneration does not supported? |
In this case, this thread is a duplicate of other thread.
That one will be tricky to implement. We could discuss it separately after this RFC is completed.
Implementing
You're right @janus-reith. That removes the need for SQS even though I think AWS still uses a queue behind the scenes for async invocations, but if is abstracting it away from us that's best! My only remaining concern would be latency between regions, say that a user is in us-east-1 and hits one of the edge functions in that region, when invoking the other lambda for background page regeneration what latency are we expected to see? I realise that it won't need to wait for the regeneration lambda to process but the request itself to put the event in the queue what region is that happening and how do we know is not going to a queue somewhere in Originally posted by @danielcondemarin in #355 (comment) To fix it, we need to make the fallback page never cached, so the lambda can return the newly generated page (and cache it) the next time the same route is hit. But we also need to version the pages properly as I realized we are not clearing them properly (we only have one set of pages under static-pages, so subsequent deploys may pick up an old version). Originally posted by @dphang in #798 (comment) Also :
Can one adds this feature to the schedule ? This RFC is older than the v10, back to 9.4 👍 |
This can be closed now as revalidate is implemented already (using SQS queue). Please report any issues in: #1098 |
Describe the bug
Is unstable_revalidate supported?
The text was updated successfully, but these errors were encountered: