Update fs-extra to remove "dependency" on ncp #532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like coveralls was down during the build, so it didn't report the results. |
|
I will retrigger the build
…On Wed, Aug 14, 2019 at 7:15 PM Neil Locketz ***@***.***> wrote:
Looks like coveralls was down during the build, so it didn't report the
results.
I'm not sure how to re-run it intentionally, haha.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#532?email_source=notifications&email_token=ABKEZXST7LT65X6N2BAZCE3QEQ4S7A5CNFSM4ILM6R4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4JPMNY#issuecomment-521336375>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABKEZXXGOET2HU75YFDZJC3QEQ4S7ANCNFSM4ILM6R4A>
.
|
|
@HyperBrain doesn't seem to have worked? |
|
Ok. I'll check this evening
…On Tue, Aug 20, 2019 at 7:45 PM Neil Locketz ***@***.***> wrote:
@HyperBrain <https://github.com/HyperBrain> doesn't seem to have worked?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#532?email_source=notifications&email_token=ABKEZXQBLTWVPTT6L2Y33WTQFQUTBA5CNFSM4ILM6R4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4XDKNA#issuecomment-523121972>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABKEZXSNDFX6NBJ45OGBQWTQFQUTBANCNFSM4ILM6R4A>
.
|
|
I restarted the build :-) |
|
@HyperBrain This is causing issues for me as well. Waiting on this to be merged. |
|
Will take care of it very soon
…On Mon, Aug 26, 2019 at 5:25 PM Nicholas Smith ***@***.***> wrote:
@HyperBrain <https://github.com/HyperBrain> This is causing issues for me
as well. Waiting on this to be merged.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#532?email_source=notifications&email_token=ABKEZXSHHP56AWH4BNYU6LLQGPYXFA5CNFSM4ILM6R4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5EWYUQ#issuecomment-524905554>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABKEZXWADH2POEPWGTN3SWLQGPYXFANCNFSM4ILM6R4A>
.
|
|
I'll fix the conflicts. |
|
@c0d3d Can you check if the changes are still needed. I began merging from old to new PRs and saw that the dependency update PR already updates fs-extra. |
|
@HyperBrain interestingly enough, someone seems to have updated everything already on July 23rd (after this was opened). They actually took care of this update, haha. |
|
@c0d3d Nevertheless thank you for the PR. I hope this does not prevent you to help with the project in the future 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Sometimes the callback to
fse.copydoes not get called causing silent failure. Turns out that the version offs-extrafor this project is very old, and there seems to have been a fix for this issue already. They used to use a copy of ncp, but no longer do as it seems that ncp is no longer maintained.How did you implement it:
Updated the version, and verified that things were still working.
How can we verify it:
For me this was happening most times when setting to package
individually.After updating the version the problems disappeared.
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO