Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name collision between Spectral and Cloud bands #131

Closed
BastienKovac opened this issue Mar 14, 2024 · 4 comments
Closed

Name collision between Spectral and Cloud bands #131

BastienKovac opened this issue Mar 14, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@BastienKovac
Copy link

Describe the bug

The CloudsBandNames.CIRRUS and SpectralBandNames.SWIR_CIRRUS have the same string name ("CIRRUS"), meaning getting the Cloud band by name by using the to_band() method is currently impossible (as the spectral one is tried first)

Code To Reproduce

from eoreader.bands import to_band
print(to_band("CIRRUS"))

Output

[<SpectralBandNames.SWIR_CIRRUS: 'CIRRUS'>]

Environment:

  • Python version: 3.8.18
  • eoreader version: 0.19.4
@BastienKovac BastienKovac added the bug Something isn't working label Mar 14, 2024
@remi-braun
Copy link
Member

Good one this one 😅

remi-braun added a commit that referenced this issue Mar 14, 2024
@remi-braun
FIX: Correct SWIR_CIRRUS spectral band's enum value (to `SWIR_CIRRU…
10ae28c 
…S` instead of `CIRRUS`), avoiding shadowing cloud band `CIRRUS` #131
@remi-braun
Copy link
Member

This should be corrected 😅
Do you need a release for that or using the latest version from Github is enough for now?

@BastienKovac
Copy link
Author

Thanks for the quick fix !

I've implemented a quick work-around for my use-case so it can definitely wait for a future release

@remi-braun
Copy link
Member

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BastienKovac @remi-braun