Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【fix】启动参数支持索引环境变量 #985

Merged
merged 1 commit into from
Nov 26, 2022

Conversation

lilai23
Copy link
Collaborator

@lilai23 lilai23 commented Nov 26, 2022

【修复issue】#984

【修改内容】启动参数appName等支持以${环境变量名:默认值}的方式索引环境变量

【用例描述】增加UT

【自测情况】UT测试通过

【影响范围】bootstrap.properties启动参数配置,心跳接收应用名配置等

@codecov
Copy link

codecov bot commented Nov 26, 2022

Codecov Report

Base: 44.34% // Head: 44.34% // No change to project coverage 👍

Coverage data is based on head (a931abd) compared to base (538f580).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #985   +/-   ##
==========================================
  Coverage      44.34%   44.34%           
  Complexity      2807     2807           
==========================================
  Files            662      662           
  Lines          14657    14657           
  Branches        1633     1633           
==========================================
  Hits            6500     6500           
  Misses          7375     7375           
  Partials         782      782           
Flag Coverage Δ
unittests 44.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@robotLJW robotLJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@robotLJW robotLJW added kind/bug Something isn't working area/framework Issues or PRs releated to sermant core service status/lgtm Indicates that a PR is ready to be merged. labels Nov 26, 2022
@robotLJW robotLJW added this to the v0.8.0 milestone Nov 26, 2022
@robotLJW robotLJW merged commit 50d147e into sermant-io:develop Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/framework Issues or PRs releated to sermant core service kind/bug Something isn't working status/lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants