【feature】优化properties和config.yaml配置文件驼峰和中划线支持以及相应环境变量读取 #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilai23
requested review from
justforstudy-A,
provenceee,
robotLJW and
xuezechao1
xuezechao1
previously approved these changes
Aug 19, 2022
...-agentcore-core/src/main/java/com/huaweicloud/sermant/core/config/utils/ConfigValueUtil.java
Outdated
Show resolved
Hide resolved
...-agentcore-core/src/main/java/com/huaweicloud/sermant/core/config/utils/ConfigValueUtil.java
Show resolved
Hide resolved
...-agentcore-core/src/main/java/com/huaweicloud/sermant/core/config/utils/ConfigValueUtil.java
Show resolved
Hide resolved
provenceee
reviewed
Aug 19, 2022
...-agentcore-core/src/main/java/com/huaweicloud/sermant/core/config/utils/ConfigValueUtil.java
Outdated
Show resolved
Hide resolved
justforstudy-A
previously approved these changes
Aug 19, 2022
provenceee
previously approved these changes
Aug 19, 2022
(1)通过在属性appName上添加@ConfigFieldKey("app-name")注解，可以在properties或yaml用中划线替换驼峰形式的键值(兼容驼峰形式)。
(2)xxx.xxx.appName将会直接以xxx.xxx.appName和解析为xxx.xxx.app.Name再通过KeyFormatter读取环境变量
(3)xxx.xxx.app-name将会被解析为xxx.xxx.app.Name再通过KeyFormatter读取环境变量
lilai23
dismissed stale reviews from provenceee and justforstudy-A
via
b1ed7fc
lilai23
changed the title
xuezechao1
approved these changes
Aug 22, 2022
justforstudy-A
approved these changes
Aug 23, 2022
robotLJW
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【issue号/问题单号/需求单号】#649
【修改内容】优化properties和yaml配置文件数据格式支持以及环境变量读取
(1)通过在属性appName上添加@ConfigFieldKey("app-name")注解(举例)，可以在properties或yaml用中划线替换驼峰形式的键值(兼容驼峰形式)。
(2)config.yaml中xxx.xxx.appName将会直接以xxx.xxx.appName和解析为xxx.xxx.app.Name再通过KeyFormatter读取环境变量
(3)config.yaml中xxx.xxx.app-name将会被解析为xxx.xxx.app.Name再通过KeyFormatter读取环境变量
【用例描述】暂无用例
【自测情况】UT测试通过
【影响范围】config.properties、config.yaml配置