Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the performance of xds flow control functionality #1730

Merged

Conversation

hanbingleixue
Copy link
Collaborator

@hanbingleixue hanbingleixue commented Jan 3, 2025

What type of PR is this?

Enhancement

What this PR does / why we need it?

Optimize the performance of xds flow control functionality

Which issue(s) this PR fixes?

Fixes #1729 #1515

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

@hanbingleixue hanbingleixue force-pushed the xds-flowcontrol-service-1 branch from 954e6c4 to d891485 Compare January 3, 2025 07:44
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 216 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../flowcontrol/AbstractXdsHttpClientInterceptor.java 0.00% 41 Missing ⚠️
...owcontrol/res4j/chain/AbstractXdsChainHandler.java 9.09% 30 Missing ⚠️
...nt/HttpUrlConnectionResponseStreamInterceptor.java 0.00% 20 Missing ⚠️
...mant/flowcontrol/DispatcherServletInterceptor.java 21.73% 16 Missing and 2 partials ⚠️
...mant/flowcontrol/retry/handler/RetryHandlerV2.java 6.25% 15 Missing ⚠️
.../flowcontrol/res4j/chain/XdsHandlerChainEntry.java 0.00% 15 Missing ⚠️
...chain/handler/XdsBusinessServerRequestHandler.java 8.33% 11 Missing ⚠️
...rmant/flowcontrol/res4j/chain/XdsHandlerChain.java 0.00% 9 Missing ⚠️
...l/res4j/service/XdsHttpFlowControlServiceImpl.java 0.00% 7 Missing ⚠️
...control/retry/client/OkHttp3ClientInterceptor.java 0.00% 6 Missing ⚠️
... and 14 more
Flag Coverage Δ Complexity Δ
unittests 42.49% <14.28%> (-0.06%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...control/common/handler/AbstractRequestHandler.java 90.00% <ø> (+11.73%) 0.00 <0.00> (ø)
...ermant/flowcontrol/common/handler/retry/Retry.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...flowcontrol/common/handler/retry/RetryContext.java 80.00% <ø> (+16.84%) 0.00 <0.00> (ø)
...l/common/xds/circuit/XdsCircuitBreakerManager.java 77.77% <ø> (+11.11%) 0.00 <0.00> (ø)
...ant/flowcontrol/retry/FeignRequestInterceptor.java 37.30% <ø> (ø) 0.00 <0.00> (ø)
...mant/flowcontrol/retry/HttpRequestInterceptor.java 42.70% <100.00%> (ø) 0.00 <0.00> (ø)
.../flowcontrol/res4j/chain/AbstractChainHandler.java 92.85% <ø> (-2.39%) 0.00 <0.00> (ø)
...ant/flowcontrol/res4j/chain/HandlerChainEntry.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...wcontrol/retry/AlibabaDubboInvokerInterceptor.java 49.47% <0.00%> (ø) 0.00 <0.00> (ø)
...owcontrol/retry/ApacheDubboInvokerInterceptor.java 46.46% <0.00%> (ø) 0.00 <0.00> (ø)
... and 22 more

... and 5 files with indirect coverage changes

@hanbingleixue hanbingleixue force-pushed the xds-flowcontrol-service-1 branch from d891485 to 1abd10c Compare January 3, 2025 08:13
@hanbingleixue hanbingleixue force-pushed the xds-flowcontrol-service-1 branch 2 times, most recently from fc95e3f to 63fa579 Compare January 6, 2025 02:50
@hanbingleixue hanbingleixue force-pushed the xds-flowcontrol-service-1 branch from 63fa579 to aaf7d57 Compare January 6, 2025 03:44
@Sherlockhan Sherlockhan merged commit e5e9567 into sermant-io:develop Jan 6, 2025
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize the performance of xDS flow control function
4 participants