-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some bugs in xds flow control #1725
Merged
Sherlockhan
merged 1 commit into
sermant-io:develop
from
hanbingleixue:xds-flowcontrol-service-1
Jan 3, 2025
Merged
Fix some bugs in xds flow control #1725
Sherlockhan
merged 1 commit into
sermant-io:develop
from
hanbingleixue:xds-flowcontrol-service-1
Jan 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daizhenyu
reviewed
Jan 2, 2025
...wcontrol-common/src/main/java/io/sermant/flowcontrol/common/handler/retry/AbstractRetry.java
Outdated
Show resolved
Hide resolved
daizhenyu
reviewed
Jan 2, 2025
...n/src/main/java/io/sermant/flowcontrol/retry/client/HttpUrlConnectionConnectInterceptor.java
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Jan 2, 2025
...trol/flowcontrol-common/src/main/java/io/sermant/flowcontrol/common/handler/retry/Retry.java
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Jan 2, 2025
...trol/flowcontrol-common/src/main/java/io/sermant/flowcontrol/common/handler/retry/Retry.java
Outdated
Show resolved
Hide resolved
lilai23
changed the title
Fix the issue of xds flow control function test
Fix some bugs in xds flow control
Jan 2, 2025
lilai23
reviewed
Jan 2, 2025
.../flowcontrol-common/src/main/java/io/sermant/flowcontrol/common/util/XdsThreadLocalUtil.java
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Jan 2, 2025
.../flowcontrol-common/src/main/java/io/sermant/flowcontrol/common/util/XdsThreadLocalUtil.java
Outdated
Show resolved
Hide resolved
hanbingleixue
force-pushed
the
xds-flowcontrol-service-1
branch
6 times, most recently
from
January 3, 2025 05:03
1a9348e
to
2d8792b
Compare
daizhenyu
previously approved these changes
Jan 3, 2025
Signed-off-by: hanbingleixue <[email protected]>
hanbingleixue
force-pushed
the
xds-flowcontrol-service-1
branch
from
January 3, 2025 06:18
2d8792b
to
3626542
Compare
lilai23
approved these changes
Jan 3, 2025
daizhenyu
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug
What this PR does / why we need it?
Fix the issue of xds flow control function test,The following test questions are included:
1、OKHTTP error injection failure
2、The xDS flow control instance circuit breaker function does not take effect When the number of failures reaches the threshold,
3、The request circuit breaker function of the flow control plug-in xDS flow control function does not take effect.
4、The xDS flow control function of the flow control plugin does not take effect when the httpurlconnection retries.
5、If the xDS flow control capability of the flow control plug-in is enabled and the xDS flow control rule is not configured, the service fails to be invoked.
6、The xDS flow control server fails to limit the traffic.
Which issue(s) this PR fixes?
Fixes #1724 #1515
Does this PR introduce a user-facing change?
No
Checklist