Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix args cannot take effect when dynamic install sermant agent with external agent and instance selectable condition in Backend #1715

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

lilai23
Copy link
Collaborator

@lilai23 lilai23 commented Dec 26, 2024

What type of PR is this?

Bug

What this PR does / why we need it?
fix issues:
(1) Args cannot take effect when dynamic install sermant agent with external agent
(2) Offline instance can be selected in Sermant Backend

Which issue(s) this PR fixes?

Fixes #1705

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...c/main/java/io/sermant/core/AgentCoreEntrance.java 0.00% 7 Missing ⚠️
...ore/service/metric/entity/MetricCommonTagEnum.java 0.00% 1 Missing ⚠️
...mant/flowcontrol/DispatcherServletInterceptor.java 0.00% 1 Missing ⚠️
Flag Coverage Δ Complexity Δ
unittests 43.82% <25.00%> (-0.01%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...java/io/sermant/core/ext/ExternalAgentManager.java 46.93% <100.00%> (ø) 0.00 <0.00> (ø)
.../java/io/sermant/core/service/metric/api/Tags.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...mant/implement/service/xds/handler/XdsHandler.java 48.14% <ø> (+0.58%) 0.00 <0.00> (ø)
...ment/service/xds/utils/RdsProtocolTransformer.java 40.19% <ø> (ø) 0.00 <0.00> (ø)
...ry/condition/ResetBeforeRequestErrorCondition.java 50.00% <100.00%> (ø) 0.00 <0.00> (ø)
...ore/service/metric/entity/MetricCommonTagEnum.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...mant/flowcontrol/DispatcherServletInterceptor.java 50.00% <0.00%> (ø) 0.00 <0.00> (ø)
...c/main/java/io/sermant/core/AgentCoreEntrance.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

... and 2 files with indirect coverage changes

@lilai23 lilai23 force-pushed the feature_opentelemetry branch 2 times, most recently from 1df0045 to 97e3582 Compare December 27, 2024 07:26
@lilai23 lilai23 force-pushed the feature_opentelemetry branch from 97e3582 to 6ede784 Compare December 27, 2024 07:27
@Sherlockhan Sherlockhan merged commit b34b16a into sermant-io:develop Dec 30, 2024
300 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support install Otel agent in Sermant
4 participants