Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom common metric tag feature #1708

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

zwmagic
Copy link
Collaborator

@zwmagic zwmagic commented Dec 18, 2024

What type of PR is this?

Feature

What this PR does / why we need it?

Add custom common metric tag feature

Which issue(s) this PR fixes?

Fixes #1707

Does this PR introduce a user-facing change?

Yes. We will update user guide at sermant.io.

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 54 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ore/service/metric/entity/MetricCommonTagEnum.java 0.00% 25 Missing ⚠️
.../sermant/implement/service/metric/MeterMetric.java 0.00% 15 Missing ⚠️
...rmant/core/service/metric/config/MetricConfig.java 0.00% 9 Missing ⚠️
.../java/io/sermant/core/service/metric/api/Tags.java 0.00% 3 Missing ⚠️
...o/sermant/router/common/metric/MetricsManager.java 0.00% 2 Missing ⚠️
Flag Coverage Δ Complexity Δ
unittests 43.78% <0.00%> (-0.08%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...ermant/router/common/constants/RouterConstant.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...o/sermant/router/common/metric/MetricsManager.java 27.77% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/io/sermant/core/service/metric/api/Tags.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rmant/core/service/metric/config/MetricConfig.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../sermant/implement/service/metric/MeterMetric.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ore/service/metric/entity/MetricCommonTagEnum.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)

... and 2 files with indirect coverage changes

@zwmagic zwmagic force-pushed the zwmagic/common_tags branch from c7999ed to 4c7d174 Compare December 18, 2024 15:46
@zwmagic zwmagic force-pushed the zwmagic/common_tags branch from 4c7d174 to 542e708 Compare December 19, 2024 13:36
@zwmagic zwmagic force-pushed the zwmagic/common_tags branch from 542e708 to f800803 Compare December 20, 2024 07:26
@zwmagic zwmagic force-pushed the zwmagic/common_tags branch from f800803 to 7d507a9 Compare December 20, 2024 13:21
@zwmagic zwmagic force-pushed the zwmagic/common_tags branch from 7d507a9 to 1824bb5 Compare December 24, 2024 13:37
@zwmagic zwmagic force-pushed the zwmagic/common_tags branch from 39cd964 to b3eca51 Compare December 24, 2024 13:38
@Sherlockhan Sherlockhan merged commit b669b3b into sermant-io:develop Dec 25, 2024
300 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide more default monitoring indicators
4 participants