Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the common module with XDS circuit breaker and rate limiting function #1700

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

hanbingleixue
Copy link
Collaborator

@hanbingleixue hanbingleixue commented Dec 13, 2024

What type of PR is this?

Feature

What this PR does / why we need it?

Add the common part of Xds flow control plugin

Which issue(s) this PR fixes?

Fixes #1515

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

@hanbingleixue hanbingleixue force-pushed the xds-flowcontrol branch 10 times, most recently from 19a02d0 to f2adfa8 Compare December 19, 2024 03:14
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 50.94340% with 182 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ant/flowcontrol/common/xds/handler/XdsHandler.java 25.00% 50 Missing and 10 partials ⚠️
...ermant/flowcontrol/common/util/XdsRouterUtils.java 52.17% 18 Missing and 4 partials ⚠️
...l/common/xds/circuit/XdsCircuitBreakerManager.java 66.66% 9 Missing and 12 partials ⚠️
...trol/common/xds/ratelimit/XdsRateLimitManager.java 0.00% 19 Missing ⚠️
...ontrol/common/core/match/XdsRouteMatchManager.java 60.97% 8 Missing and 8 partials ⚠️
...wcontrol/common/xds/lb/XdsLoadBalancerFactory.java 0.00% 12 Missing ⚠️
...ment/service/xds/utils/RdsProtocolTransformer.java 0.00% 10 Missing ⚠️
...ntrol/common/xds/lb/XdsRoundRobinLoadBalancer.java 0.00% 9 Missing ⚠️
...flowcontrol/common/entity/FlowControlResponse.java 0.00% 7 Missing ⚠️
...owcontrol/common/xds/lb/XdsRandomLoadBalancer.java 0.00% 5 Missing ⚠️
... and 1 more
Flag Coverage Δ Complexity Δ
unittests 43.94% <50.94%> (+0.06%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...a/io/sermant/core/service/xds/entity/XdsAbort.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...a/io/sermant/core/service/xds/entity/XdsDelay.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...lowcontrol/common/config/XdsFlowControlConfig.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...flowcontrol/common/entity/FlowControlScenario.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...io/sermant/flowcontrol/common/util/RandomUtil.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...trol/common/xds/circuit/XdsCircuitBreakerInfo.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...control/common/xds/ratelimit/XdsRateLimitInfo.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...nt/flowcontrol/common/util/XdsThreadLocalUtil.java 91.66% <91.66%> (ø) 0.00 <0.00> (?)
...owcontrol/common/xds/lb/XdsRandomLoadBalancer.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...flowcontrol/common/entity/FlowControlResponse.java 62.50% <0.00%> (-25.74%) 0.00 <0.00> (ø)
... and 8 more

... and 25 files with indirect coverage changes

@hanbingleixue hanbingleixue force-pushed the xds-flowcontrol branch 3 times, most recently from fe607b1 to 50274ea Compare December 24, 2024 07:24
@hanbingleixue hanbingleixue changed the title Add the common part of Xds flow control plugin Add the common module with XDS circuit breaker and rate limiting function Dec 24, 2024
lilai23
lilai23 previously approved these changes Dec 24, 2024
@Sherlockhan Sherlockhan merged commit ff41cc7 into sermant-io:develop Dec 25, 2024
300 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supports xDS protocol to communicate with the Control Plane of Service Mesh
4 participants