Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XDS flow control function #1698

Merged

Conversation

hanbingleixue
Copy link
Collaborator

@hanbingleixue hanbingleixue commented Dec 13, 2024

What type of PR is this?

Feature

What this PR does / why we need it?

Add XDS retry and circuit-breaking functionality to the flow control plugin

Which issue(s) this PR fixes?

Fixes #1515

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

@hanbingleixue hanbingleixue force-pushed the xds-flowcontrol-service branch 5 times, most recently from 9f2744f to 91c6a96 Compare December 21, 2024 02:51
@hanbingleixue hanbingleixue force-pushed the xds-flowcontrol-service branch from 91c6a96 to 59aeeb1 Compare December 24, 2024 08:24
@hanbingleixue hanbingleixue changed the title Add XDS retry and circuit-breaking functionality to the flow control plugin Add XDS flow control function Dec 24, 2024
@hanbingleixue hanbingleixue force-pushed the xds-flowcontrol-service branch 4 times, most recently from df935bd to 926286e Compare December 27, 2024 08:36
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 28.32168% with 205 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ol/res4j/chain/handler/XdsFaultRequestHandler.java 10.63% 41 Missing and 1 partial ⚠️
...ol/retry/handler/DefaultRetryPredicateCreator.java 0.00% 34 Missing ⚠️
...es4j/chain/handler/XdsRateLimitRequestHandler.java 12.90% 26 Missing and 1 partial ⚠️
...mant/flowcontrol/retry/handler/RetryHandlerV2.java 9.09% 20 Missing ⚠️
...mant/flowcontrol/retry/HttpRequestInterceptor.java 25.00% 15 Missing ⚠️
...chain/handler/XdsBusinessServerRequestHandler.java 16.66% 14 Missing and 1 partial ⚠️
...ant/flowcontrol/retry/FeignRequestInterceptor.java 0.00% 13 Missing ⚠️
...chain/handler/XdsBusinessClientRequestHandler.java 20.00% 11 Missing and 1 partial ⚠️
...ler/exception/XdsRateLimitingExceptionHandler.java 14.28% 12 Missing ⚠️
...mant/flowcontrol/DispatcherServletInterceptor.java 33.33% 6 Missing and 2 partials ⚠️
... and 4 more
Flag Coverage Δ Complexity Δ
unittests 43.57% <28.32%> (-0.26%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...lowcontrol/common/config/XdsFlowControlConfig.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...mant/flowcontrol/service/InterceptorSupporter.java 42.02% <100.00%> (+0.85%) 0.00 <0.00> (ø)
.../flowcontrol/res4j/chain/AbstractChainHandler.java 95.23% <100.00%> (ø) 0.00 <0.00> (ø)
...mant/flowcontrol/res4j/chain/HandlerConstants.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
.../flowcontrol/res4j/chain/context/ChainContext.java 91.66% <ø> (ø) 0.00 <0.00> (ø)
...ol/res4j/chain/handler/BulkheadRequestHandler.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...ntrol/res4j/chain/handler/FaultRequestHandler.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...chain/handler/InstanceIsolationRequestHandler.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...es4j/chain/handler/RateLimitingRequestHandler.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...ol/res4j/chain/handler/SystemServerReqHandler.java 71.42% <100.00%> (+1.05%) 0.00 <0.00> (ø)
... and 15 more

... and 8 files with indirect coverage changes

Signed-off-by: hanbingleixue <[email protected]>
@hanbingleixue hanbingleixue force-pushed the xds-flowcontrol-service branch from 926286e to a0ff1ca Compare December 30, 2024 08:29
@Sherlockhan Sherlockhan merged commit 18c63df into sermant-io:develop Dec 31, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supports xDS protocol to communicate with the Control Plane of Service Mesh
4 participants