Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: classloaders in Sermant should not load implementations of SPI interface from parent classloader #1686

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

lilai23
Copy link
Collaborator

@lilai23 lilai23 commented Nov 26, 2024

What type of PR is this?

Bug

What this PR does / why we need it?

Due to class isolation, the service loader does not obtain the service provider from the parent classloader, but returns only the SPI resources in current classloader

Which issue(s) this PR fixes?

Fixes #1685

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ant/core/plugin/classloader/PluginClassLoader.java 0.00% 3 Missing ⚠️
Flag Coverage Δ Complexity Δ
unittests 43.88% <0.00%> (-0.01%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...ant/core/plugin/classloader/PluginClassLoader.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

... and 3 files with indirect coverage changes

@Sherlockhan Sherlockhan merged commit 6975b2a into sermant-io:develop Nov 29, 2024
300 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Classloaders in Sermant should not load implementations of SPI interface from parent classloader
4 participants