Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DefaultAdviser log #1682

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Fix DefaultAdviser log #1682

merged 1 commit into from
Nov 26, 2024

Conversation

provenceee
Copy link
Collaborator

What type of PR is this?

Bug

What this PR does / why we need it?

Fix DefaultAdviser log

Which issue(s) this PR fixes?

Fixes #1666

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

Signed-off-by: provenceee <[email protected]>
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...c/main/java/io/sermant/core/AgentCoreEntrance.java 0.00% 1 Missing ⚠️
Flag Coverage Δ Complexity Δ
unittests 44.21% <50.00%> (-0.01%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...ain/java/io/sermant/core/common/LoggerFactory.java 20.00% <100.00%> (ø) 0.00 <0.00> (ø)
...c/main/java/io/sermant/core/AgentCoreEntrance.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

... and 1 file with indirect coverage changes

@lilai23 lilai23 merged commit 004bc9c into sermant-io:2.1.x Nov 26, 2024
281 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants