Fix Nacos reconnection failed continuously issue with message "com.alibaba.nacos.common.remote.exception.RemoteException: errCode: 500, errMsg: Unknown payload type:ServerCheckResponse" but actually the connection is already established.

[rztao]

Fix Nacos reconnection failed continuously issue with message "com.alibaba.nacos.common.remote.exception.RemoteException: errCode: 500, errMsg: Unknown payload type:ServerCheckResponse" but actually the connection is already established because PayloadRegistry without initializing due to incorrect ClassLoader when creating Nacos client

What type of PR is this?

Bug

What this PR does / why we need it?

Nacos reconnection always failed because PayloadRegistry without initializing due to incorrect ClassLoader when creating Nacos client, This PR will fix it.

Which issue(s) this PR fixes？

Fixes # Nacos client will reconnect to Nacos server when connection is lost and it will depend on PayloadRegistry initializing correctly so RpcClient can found response class to deserialize the response data.

Here is the error stack trace profiling by Arthas.

com.alibaba.nacos.common.remote.exception.RemoteException: errCode: 500, errMsg: Unknown payload type:ServerCheckResponse at com.alibaba.nacos.common.remote.client.grpc.GrpcUtils.parse(GrpcUtils.java:133) at com.alibaba.nacos.common.remote.client.grpc.GrpcClient.serverCheck(GrpcClient.java:198) at com.alibaba.nacos.common.remote.client.grpc.GrpcClient.connectToServer(GrpcClient.java:307) at com.alibaba.nacos.common.remote.client.RpcClient.reconnect(RpcClient.java:498) at com.alibaba.nacos.common.remote.client.RpcClient.lambda$start$2(RpcClient.java:339) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748)

but actually the reconnect response from Nacos server is success with 200 status code.
body_=@Any[ serialVersionUID=@Long[0], cachedUnpackValue=null, TYPE_URL_FIELD_NUMBER=@Integer[1], typeUrl_=@String[], VALUE_FIELD_NUMBER=@Integer[2], value_=@LiteralByteString[<ByteString@478c0716 size=98 contents="{\"resultCode\":200,\"errorCode\":0,\"connectionId\":...">], memoizedIsInitialized=@Byte[-1], DEFAULT_INSTANCE=@Any[], PARSER=@[com.alibaba.nacos.shaded.com.google.protobuf.Any$1@4e975aba], serialVersionUID=@Long[1], alwaysUseFieldBuilders=@Boolean[false], unknownFields=@UnknownFieldSet[], memoizedSize=@Integer[-1], memoizedHashCode=@Integer[0], ],

Here is the code from GrpcUtils.parse method.

And the REGISTRY_REQUEST map from PayloadRegistry is empty but it is initialized

[arthas@1]$ ognl -classLoaderClass com.huaweicloud.sermant.core.classloader.FrameworkClassLoader "@com.alibaba.nacos.common.remote.PayloadRegistry@REGISTRY_REQUEST" @HashMap[isEmpty=true;size=0] [arthas@1]$

Does this PR introduce a user-facing change?

No

Checklist

• Make sure there is a GitHub_issue related with this PR before you start working on it.
• Make sure you have squashed your change to one single commit.
• GitHub Actions works fine in this PR.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...registry/service/register/NacosServiceManager.java	0.00%	8 Missing ⚠️
...rmant/dubbo/registry/utils/NamingServiceUtils.java	0.00%	3 Missing ⚠️

Flag	Coverage Δ	Complexity Δ
unittests	43.95% <0.00%> (-0.02%)	181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ	Complexity Δ
...rmant/dubbo/registry/utils/NamingServiceUtils.java	48.38% <0.00%> (-5.19%)	0.00 <0.00> (ø)
...registry/service/register/NacosServiceManager.java	40.47% <0.00%> (-6.75%)	0.00 <0.00> (ø)

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[provenceee]

This is a bug of nacos-client. For details, see nacos issue 11139.

[rztao]

This is a bug of nacos-client. For details, see nacos issue 11139.

The exception is different: nacos issue 11139 is ClassCastException, for this issue is com.alibaba.nacos.common.remote.exception.RemoteException: errCode: 500, errMsg: Unknown payload type:ServerCheckResponse just because PayloadRegistry is not correctly initialized using BootstrapClassLoader not usingFrameworkClassLoader.

The code for PayloadRegistry.scan is also different from the code pasted from 11139.

We tested it in our online environment, it worked without nacos-client version change.

This is a bug of nacos-client. For details, see nacos issue 11139.