Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rocketmq gray plugin workflow test #1660

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

chengyouling
Copy link
Collaborator

@chengyouling chengyouling commented Nov 7, 2024

What type of PR is this?

UT tests

What this PR does / why we need it?

Function coverage test for mq grayscale.

Which issue(s) this PR fixes?

#1659

Does this PR introduce a user-facing change?

No

@chengyouling chengyouling self-assigned this Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ Complexity Δ
unittests 43.87% <ø> (ø) 181.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@chengyouling chengyouling force-pushed the develop-utest branch 2 times, most recently from 18a1251 to 5c338d0 Compare November 7, 2024 03:44
@chengyouling chengyouling changed the title 增加rocketmq插件流水测试 add rocketmq gray plugin workflow test Nov 14, 2024
Comment on lines 31 to 34
* 启动类
*
* @param args 进程启动入参
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English comments are recommended.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Comment on lines 114 to 117
if (offSetTable.get(mq) != null) {
return offSetTable.get(mq);
}
return 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return map.getOrDefault(mq, 0L)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Comment on lines +53 to +56
* 构造函数
*
* @param restTemplate 请求器
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English comments are recommended.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

using: "composite"
steps:
- name: Set up JDK ${{ env.javaVersion }}
uses: actions/setup-java@v3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use v4 version for setup-java、cache、checkout action

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

strategy:
matrix:
test-model: [ 'PLUGIN_ENABLED_FALSE','CONSUMER_BASE_ONLY','CONSUMER_BASE_GRAY' ]
rocketMqClientVersion: ["4.8.0", "4.9.0", "4.9.1", "4.9.2", "4.9.3", "4.9.4", "4.9.5", "4.9.6", "4.9.7", "4.9.8", "5.0.0"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.1.x version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SubscriptionData class path changed from 5.1.x,and bug fixed later.

@chengyouling chengyouling force-pushed the develop-utest branch 22 times, most recently from d5e3acb to cba46fb Compare December 19, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants