Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric collection function to router plugin #1656

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

hanbingleixue
Copy link
Collaborator

@hanbingleixue hanbingleixue commented Oct 28, 2024

What type of PR is this?

Enhancement

What this PR does / why we need it?

Add metric collection function to router plugin
The rendering is shown as follows:
image
image

Which issue(s) this PR fixes?

Fixes #1655

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 19.20530% with 244 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...t/router/config/strategy/AbstractRuleStrategy.java 2.94% 32 Missing and 1 partial ⚠️
...o/sermant/router/common/metric/MetricsManager.java 39.53% 25 Missing and 1 partial ⚠️
...va/io/sermant/router/common/metric/MetricInfo.java 0.00% 19 Missing ⚠️
...erceptor/AlibabaDubboMonitorFilterInterceptor.java 0.00% 18 Missing ⚠️
...terceptor/ApacheDubboMonitorFilterInterceptor.java 0.00% 18 Missing ⚠️
...sermant/router/spring/handler/AbstractHandler.java 10.52% 16 Missing and 1 partial ⚠️
...ring/interceptor/HttpAsyncClient4xInterceptor.java 0.00% 17 Missing ⚠️
...eptor/OkHttpClientInterceptorChainInterceptor.java 30.00% 13 Missing and 1 partial ⚠️
...er/spring/interceptor/HttpClient4xInterceptor.java 0.00% 12 Missing ⚠️
...r/spring/interceptor/OkHttp3ClientInterceptor.java 0.00% 12 Missing ⚠️
... and 11 more
Flag Coverage Δ Complexity Δ
unittests 43.96% <19.20%> (-0.25%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
.../java/io/sermant/router/common/cache/AppCache.java 100.00% <ø> (ø) 0.00 <0.00> (?)
...ermant/router/common/constants/RouterConstant.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...mant/router/spring/handler/LaneMappingHandler.java 89.47% <100.00%> (+0.58%) 0.00 <0.00> (ø)
...t/router/spring/handler/LaneRequestTagHandler.java 89.47% <100.00%> (+0.58%) 0.00 <0.00> (ø)
...pring/interceptor/DiscoveryManagerInterceptor.java 93.75% <ø> (ø) 0.00 <0.00> (ø)
...pring/interceptor/EurekaHttpClientInterceptor.java 91.66% <ø> (ø) 0.00 <0.00> (ø)
...spring/interceptor/ServiceRegistryInterceptor.java 84.21% <ø> (ø) 0.00 <0.00> (ø)
...sermant/router/spring/utils/SpringRouterUtils.java 25.92% <ø> (ø) 0.00 <0.00> (ø)
...ermant/router/spring/handler/FlowRouteHandler.java 82.35% <ø> (ø) 0.00 <0.00> (ø)
...sermant/router/spring/handler/TagRouteHandler.java 59.09% <ø> (ø) 0.00 <0.00> (ø)
... and 22 more

... and 4 files with indirect coverage changes

@hanbingleixue hanbingleixue force-pushed the develop branch 2 times, most recently from 9022abb to 0749133 Compare October 29, 2024 09:07
@hanbingleixue hanbingleixue force-pushed the develop branch 2 times, most recently from 5f99eeb to f941eec Compare October 31, 2024 03:51
@Sherlockhan Sherlockhan merged commit 0789753 into sermant-io:develop Oct 31, 2024
298 of 299 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the metric collection functionality to router plugin
5 participants