Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the issue that xds routing fails when okhttp2.2.0 is used #1651

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

daizhenyu
Copy link
Collaborator

@daizhenyu daizhenyu commented Oct 18, 2024

What type of PR is this?

Bug.

What this PR does / why we need it?

fix the issue that xds routing fails when okhttp2.2.0 is used. The cause is that the okhttp2 earlier version uses java.net.URL instead of com.squareup.okhttp.HttpUrl.

Which issue(s) this PR fixes?

Fixes #1647

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

@daizhenyu daizhenyu force-pushed the 2.1.x-fix-okhttp-bug branch from 84ceab9 to cfead64 Compare October 24, 2024 02:48
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...eptor/OkHttpClientInterceptorChainInterceptor.java 57.14% 3 Missing ⚠️
Flag Coverage Δ Complexity Δ
unittests 44.20% <57.14%> (-0.01%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...eptor/OkHttpClientInterceptorChainInterceptor.java 72.09% <57.14%> (-3.59%) 0.00 <0.00> (ø)

... and 1 file with indirect coverage changes

@Sherlockhan Sherlockhan merged commit f04c5e0 into sermant-io:2.1.x Oct 24, 2024
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants