Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

router plugin: HttpAsyncClient xDS router #1627

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

daizhenyu
Copy link
Collaborator

@daizhenyu daizhenyu commented Sep 20, 2024

What type of PR is this?

Feature.

What this PR does / why we need it?

router plugin: supporting HttpAsyncClient xDS routing

Which issue(s) this PR fixes?

Fixes #1604

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

@daizhenyu daizhenyu force-pushed the develop-xds-router-plugin branch from ffbee10 to 6eee889 Compare September 20, 2024 09:27
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 2.89855% with 67 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ring/interceptor/HttpAsyncClient4xInterceptor.java 0.00% 44 Missing ⚠️
...ring/entity/HttpAsyncRequestProducerDecorator.java 0.00% 18 Missing ⚠️
...er/spring/interceptor/HttpClient4xInterceptor.java 0.00% 2 Missing ⚠️
...r/spring/interceptor/OkHttp3ClientInterceptor.java 0.00% 2 Missing ⚠️
...terceptor/HttpUrlConnectionConnectInterceptor.java 0.00% 1 Missing ⚠️
Flag Coverage Δ Complexity Δ
unittests 44.02% <2.89%> (-0.09%) 182.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...ermant/router/common/constants/RouterConstant.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...eptor/OkHttpClientInterceptorChainInterceptor.java 75.67% <100.00%> (+0.67%) 0.00 <0.00> (ø)
...terceptor/HttpUrlConnectionConnectInterceptor.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...er/spring/interceptor/HttpClient4xInterceptor.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...r/spring/interceptor/OkHttp3ClientInterceptor.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ring/entity/HttpAsyncRequestProducerDecorator.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ring/interceptor/HttpAsyncClient4xInterceptor.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

... and 1 file with indirect coverage changes

@daizhenyu daizhenyu force-pushed the develop-xds-router-plugin branch from 6eee889 to 5bf374b Compare September 23, 2024 07:08
hanbingleixue
hanbingleixue previously approved these changes Sep 23, 2024
@Sherlockhan Sherlockhan merged commit cb6d6a4 into sermant-io:develop Sep 24, 2024
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support obtaining Istio routing and load balancing configurations based on the xDS protocol
4 participants