Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize configuration management services #1623

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

hanbingleixue
Copy link
Collaborator

@hanbingleixue hanbingleixue commented Sep 17, 2024

What type of PR is this?

Enhancement

What this PR does / why we need it?

  1. Modify configuration query interface

  2. Modify the configuration details page and render according to the configuration template
    image
    image

  3. Add a configuration template query interface

Which issue(s) this PR fixes?

Fixes #1622

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

@hanbingleixue hanbingleixue force-pushed the develop branch 2 times, most recently from 5a34878 to ba3db27 Compare September 18, 2024 01:50
@hanbingleixue hanbingleixue force-pushed the develop branch 8 times, most recently from cf211cc to d856881 Compare September 20, 2024 01:55
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 144 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...java/io/sermant/backend/service/ConfigService.java 51.42% 22 Missing and 12 partials ⚠️
...o/sermant/backend/service/PageTemplateService.java 0.00% 29 Missing ⚠️
.../sermant/backend/yaml/FieldMappingConstructor.java 0.00% 18 Missing ⚠️
.../java/io/sermant/backend/yaml/YamlRepresenter.java 0.00% 10 Missing ⚠️
...va/io/sermant/backend/entity/template/Element.java 0.00% 9 Missing ⚠️
...rvice/dynamicconfig/zookeeper/ZooKeeperClient.java 12.50% 7 Missing ⚠️
...a/io/sermant/backend/entity/config/ConfigInfo.java 77.77% 3 Missing and 3 partials ⚠️
...ervice/dynamicconfig/kie/client/kie/KieClient.java 0.00% 5 Missing ⚠️
...mant/backend/entity/template/PageTemplateInfo.java 28.57% 5 Missing ⚠️
...ermant/backend/entity/template/ConfigTemplate.java 0.00% 4 Missing ⚠️
... and 6 more
Flag Coverage Δ Complexity Δ
unittests 43.79% <33.33%> (-0.37%) 182.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...va/io/sermant/backend/common/conf/CommonConst.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../java/io/sermant/backend/entity/config/Result.java 95.65% <100.00%> (+1.20%) 0.00 <0.00> (ø)
.../io/sermant/backend/common/conf/DynamicConfig.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ant/backend/controller/PageTemplateController.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...o/sermant/backend/controller/ConfigController.java 44.11% <70.00%> (-1.83%) 0.00 <0.00> (ø)
...ava/io/sermant/backend/entity/template/Option.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ermant/backend/entity/template/ConfigTemplate.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...o/sermant/backend/entity/template/Description.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../java/io/sermant/backend/entity/template/Name.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ervice/dynamicconfig/kie/client/kie/KieClient.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 8 more

... and 91 files with indirect coverage changes

@hanbingleixue hanbingleixue force-pushed the develop branch 4 times, most recently from eedff40 to 4dc73d7 Compare September 20, 2024 07:59
lilai23
lilai23 previously approved these changes Sep 23, 2024
daizhenyu
daizhenyu previously approved these changes Sep 25, 2024
@Sherlockhan Sherlockhan merged commit 0f6afb4 into sermant-io:develop Sep 26, 2024
282 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize configuration management services
4 participants