Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

router plugin: interceptor with xDS router #1621

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

daizhenyu
Copy link
Collaborator

@daizhenyu daizhenyu commented Sep 14, 2024

What type of PR is this?

Feature.

What this PR does / why we need it?

router plugin: interceptor with xDS router, include:

  1. HttpClient4.x
  2. OkHttp2.x+
  3. HttpUrlConnection
  4. SpringCloud

Which issue(s) this PR fixes?

Fixes #1604

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 32.82443% with 176 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...er/spring/interceptor/HttpClient4xInterceptor.java 0.00% 44 Missing ⚠️
...terceptor/HttpUrlConnectionConnectInterceptor.java 0.00% 39 Missing ⚠️
...r/spring/interceptor/OkHttp3ClientInterceptor.java 0.00% 29 Missing ⚠️
...pring/interceptor/BaseLoadBalancerInterceptor.java 45.83% 10 Missing and 3 partials ⚠️
...sermant/router/spring/utils/SpringRouterUtils.java 20.00% 11 Missing and 1 partial ⚠️
...er/spring/interceptor/LoadBalancerInterceptor.java 31.25% 9 Missing and 2 partials ⚠️
...ceptor/ServiceInstanceListSupplierInterceptor.java 31.25% 9 Missing and 2 partials ⚠️
...eptor/OkHttpClientInterceptorChainInterceptor.java 75.00% 7 Missing and 2 partials ⚠️
...declarer/OkHttpClientInterceptorChainDeclarer.java 0.00% 4 Missing ⚠️
.../io/sermant/router/common/config/RouterConfig.java 50.00% 3 Missing ⚠️
... and 1 more
Flag Coverage Δ Complexity Δ
unittests 44.10% <32.82%> (-0.04%) 182.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
.../router/spring/declarer/OkHttp3ClientDeclarer.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...rmant/router/spring/utils/BaseHttpRouterUtils.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...declarer/BaseRegistryPluginAdaptationDeclarer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../io/sermant/router/common/config/RouterConfig.java 57.14% <50.00%> (-1.00%) 0.00 <0.00> (ø)
...declarer/OkHttpClientInterceptorChainDeclarer.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...eptor/OkHttpClientInterceptorChainInterceptor.java 75.00% <75.00%> (ø) 0.00 <0.00> (?)
...er/spring/interceptor/LoadBalancerInterceptor.java 61.29% <31.25%> (-32.83%) 0.00 <0.00> (ø)
...ceptor/ServiceInstanceListSupplierInterceptor.java 56.41% <31.25%> (-19.59%) 0.00 <0.00> (ø)
...sermant/router/spring/utils/SpringRouterUtils.java 31.81% <20.00%> (-22.73%) 0.00 <0.00> (ø)
...pring/interceptor/BaseLoadBalancerInterceptor.java 62.50% <45.83%> (-13.02%) 0.00 <0.00> (ø)
... and 3 more

... and 3 files with indirect coverage changes

@Issues-translate-bot
Copy link

Detect the issue's language is not English and translate it automatically.


Codecov Report

Attention: Patch coverage is 32.82443% with 176 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...er/spring/interceptor/HttpClient4xInterceptor.java 0.00% 44 Missing ⚠️
...terceptor/HttpUrlConnectionConnectInterceptor.java 0.00% 39 Missing ⚠️
...r/spring/interceptor/OkHttp3ClientInterceptor.java 0.00% 29 Missing ⚠️
...pring/interceptor/BaseLoadBalancerInterceptor.java 45.83% 10 Missing and 3 partials ⚠️
...sermant/router/spring/utils/SpringRouterUtils.java 20.00% 11 Missing and 1 partial ⚠️
...er/spring/interceptor/LoadBalancerInterceptor.java 31.25% 9 Missing and 2 partials ⚠️
...ceptor/ServiceInstanceListSupplierInterceptor.java 31.25% 9 Missing and 2 partials ⚠️
...eptor/OkHttpClientInterceptorChainInterceptor.java 75.00% 7 Missing and 2 partials ⚠️
...declarer/OkHttpClientInterceptorChainDeclarer.java 0.00% 4 Missing ⚠️
.../io/sermant/router/common/config/RouterConfig.java 50.00% 3 Missing ⚠️
... and 1 more
Flag Coverage Δ Complexity Δ
unittests 44.10% <32.82%> (-0.04%) 182.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
.../router/spring/declarer/OkHttp3ClientDeclarer.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...rmant/router/spring/utils/BaseHttpRouterUtils.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...declarer/BaseRegistryPluginAdaptationDeclarer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../io/sermant/router/common/config/RouterConfig.java 57.14% <50.00%> (-1.00%) 0.00 <0.00> (ø)
...declarer/OkHttpClientInterceptorChainDeclarer.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...eptor/OkHttpClientInterceptorChainInterceptor.java 75.00% <75.00%> (ø) 0.00 <0.00> (?)
...er/spring/interceptor/LoadBalancerInterceptor.java 61.29% <31.25%> (-32.83%) 0.00 <0.00> (ø)
...ceptor/ServiceInstanceListSupplierInterceptor.java 56.41% <31.25%> (-19.59%) 0.00 <0.00> (ø)
...sermant/router/spring/utils/SpringRouterUtils.java 31.81% <20.00%> (-22.73%) 0.00 <0.00> (ø)
...pring/interceptor/BaseLoadBalancerInterceptor.java 62.50% <45.83%> (-13.02%) 0.00 <0.00> (ø)
... and 3 more

... and 3 files with indirect coverage changes

@Sherlockhan Sherlockhan merged commit 2de8230 into sermant-io:develop Sep 20, 2024
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support obtaining Istio routing and load balancing configurations based on the xDS protocol
5 participants