Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

router plugin: xDS router common module #1617

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

daizhenyu
Copy link
Collaborator

@daizhenyu daizhenyu commented Sep 12, 2024

What type of PR is this?

Feature.

What this PR does / why we need it?

xDS router common module of router plugin:

  1. xDSrouteHandler
  2. loadbalancer

Which issue(s) this PR fixes?

Fixes #1604

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

@daizhenyu daizhenyu force-pushed the develop-xds-route-930 branch from abe119e to c21bc86 Compare September 12, 2024 01:51
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 71.72414% with 41 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...io/sermant/router/common/xds/XdsRouterHandler.java 76.62% 8 Missing and 10 partials ⚠️
...io/sermant/router/common/utils/XdsRouterUtils.java 74.19% 4 Missing and 4 partials ⚠️
.../main/java/io/sermant/core/utils/NetworkUtils.java 0.00% 7 Missing ⚠️
...t/router/common/xds/lb/XdsLoadBalancerFactory.java 68.75% 3 Missing and 2 partials ⚠️
...outer/common/xds/lb/XdsRoundRobinLoadBalancer.java 66.66% 2 Missing and 1 partial ⚠️
Flag Coverage Δ Complexity Δ
unittests 44.14% <71.72%> (+0.16%) 182.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...nt/router/common/xds/lb/XdsRandomLoadBalancer.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...outer/common/xds/lb/XdsRoundRobinLoadBalancer.java 66.66% <66.66%> (ø) 0.00 <0.00> (?)
...t/router/common/xds/lb/XdsLoadBalancerFactory.java 68.75% <68.75%> (ø) 0.00 <0.00> (?)
.../main/java/io/sermant/core/utils/NetworkUtils.java 17.46% <0.00%> (-2.19%) 0.00 <0.00> (ø)
...io/sermant/router/common/utils/XdsRouterUtils.java 74.19% <74.19%> (ø) 0.00 <0.00> (?)
...io/sermant/router/common/xds/XdsRouterHandler.java 76.62% <76.62%> (ø) 0.00 <0.00> (?)

... and 3 files with indirect coverage changes

@daizhenyu daizhenyu force-pushed the develop-xds-route-930 branch from c21bc86 to 7176314 Compare September 13, 2024 07:09
@daizhenyu daizhenyu force-pushed the develop-xds-route-930 branch 2 times, most recently from 9988d20 to 7e11e49 Compare September 13, 2024 09:09
@daizhenyu daizhenyu force-pushed the develop-xds-route-930 branch from 7e11e49 to 623e58f Compare September 13, 2024 09:27
@Sherlockhan Sherlockhan merged commit 3d80209 into sermant-io:develop Sep 18, 2024
281 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support obtaining Istio routing and load balancing configurations based on the xDS protocol
4 participants