Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds route and lb service #1615

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

daizhenyu
Copy link
Collaborator

@daizhenyu daizhenyu commented Sep 5, 2024

What type of PR is this?

Feature.

What this PR does / why we need it?

xds route and lb service, contains:

  1. rds and cds handler
  2. route and lb service

Which issue(s) this PR fixes?

Fixes #1604

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 81.36364% with 41 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...mant/implement/service/xds/XdsCoreServiceImpl.java 0.00% 12 Missing ⚠️
...mant/implement/service/xds/cache/XdsDataCache.java 81.13% 6 Missing and 4 partials ⚠️
...service/xds/discovery/XdsServiceDiscoveryImpl.java 70.00% 4 Missing and 2 partials ⚠️
...mant/implement/service/xds/handler/XdsHandler.java 54.54% 4 Missing and 1 partial ⚠️
...mant/implement/service/xds/handler/CdsHandler.java 86.66% 2 Missing ⚠️
...mant/implement/service/xds/handler/LdsHandler.java 91.66% 2 Missing ⚠️
...mant/implement/service/xds/handler/RdsHandler.java 87.50% 2 Missing ⚠️
...ment/service/xds/utils/EdsProtocolTransformer.java 92.30% 1 Missing and 1 partial ⚠️
Flag Coverage Δ Complexity Δ
unittests 43.54% <81.36%> (+0.27%) 182.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...re/service/xds/entity/XdsClusterLoadAssigment.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...o/sermant/core/service/xds/entity/XdsLocality.java 84.84% <100.00%> (+4.84%) 0.00 <0.00> (ø)
...ice/xds/entity/XdsServiceClusterLoadAssigment.java 85.18% <100.00%> (+3.36%) 0.00 <0.00> (ø)
...mant/implement/service/xds/handler/EdsHandler.java 86.66% <100.00%> (+4.31%) 0.00 <0.00> (ø)
...ice/xds/loadbalance/XdsLoadBalanceServiceImpl.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...plement/service/xds/route/XdsRouteServiceImpl.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...mant/implement/service/xds/handler/CdsHandler.java 94.28% <86.66%> (+0.16%) 0.00 <0.00> (ø)
...mant/implement/service/xds/handler/LdsHandler.java 91.66% <91.66%> (ø) 0.00 <0.00> (?)
...mant/implement/service/xds/handler/RdsHandler.java 87.50% <87.50%> (ø) 0.00 <0.00> (?)
...ment/service/xds/utils/EdsProtocolTransformer.java 83.07% <92.30%> (ø) 0.00 <0.00> (?)
... and 4 more

... and 33 files with indirect coverage changes

@daizhenyu daizhenyu force-pushed the develop-xds-route-930 branch 2 times, most recently from 67e01b5 to 570d039 Compare September 10, 2024 02:33
hanbingleixue
hanbingleixue previously approved these changes Sep 10, 2024
Signed-off-by: daizhenyu <[email protected]>
@Sherlockhan Sherlockhan merged commit cdc2c66 into sermant-io:develop Sep 11, 2024
280 of 281 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support obtaining Istio routing and load balancing configurations based on the xDS protocol
4 participants